perf: Reimplement permissions fetching to do it in a single transaction #21156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21156 +/- ##
===========================================
- Coverage 66.27% 54.89% -11.38%
===========================================
Files 1770 1779 +9
Lines 67543 67838 +295
Branches 7185 7237 +52
===========================================
- Hits 44764 37242 -7522
- Misses 20940 28744 +7804
- Partials 1839 1852 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bkyryliuk
force-pushed
the
bogdan/optimize_perm_lookup
branch
11 times, most recently
from
1803d96
to
c38925c
Compare
bkyryliuk
force-pushed
the
bogdan/optimize_perm_lookup
branch
from
c38925c
to
84e0546
Compare
sadpandajoe
added a commit
to preset-io/superset
that referenced
this pull request
Aug 31, 2022
…tion (apache#21156)" This reverts commit ed6212a.
zephyring
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 2, 2022
…tion (apache#21156)" This reverts commit ed6212a
zephyring
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 2, 2022
…tion (apache#21156)" This reverts commit ed6212a
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Reimplement permissions fetching to do it in a single transaction.
It reduces latency from ~1 second to ~120 ms on our deployment
BEFORE
AFTER
TESTING INSTRUCTIONS
[x] CI
[x] Dropbox Staging